Update for Rails 4.2.3

[petelouise]

Allows newer versions of ActiveRecord.
Fixes make_flaggable_spec so that it will run, but does not fix make_flaggable_generator_spec since it requires a change in the generator_spec gem.

[jhanggi]

What did you do in order to make these changes? Was it just running a db:migrate?

[petelouise]

I added them by hand. They would have become necessary after the counter cache was added, but no one updated the specs.

[jhanggi]

Was make_flaggable_generator_spec broken before the upgrade? What sort of change does it need?

[petelouise]

Yes, all of the specs were broken before the upgrade. Even before I made any changes to the repo, none of the specs would run. Some of them were due to config problems, and then the test schema didn't have the right columns.

There is a custom matcher in the generator_spec gem that I think is causing problems, but I didn't spend a lot of time looking into it. The only spec that's failing is one about the generator creating files in the correct places. Ideally, the spec and generator should be updated with the columns needed for counter_cache. But since we're not using the generator in GS, I figured it didn't make sense to fix up everything.

[jhanggi]

I think we should maintain the >= 3.0 because I do believe it relies on syntax from AR 3. And we should issue a PR against the original with all these changes. I'd be comfortable we just said >= 3.0 without the any upper limit.

[petelouise]

Updated:

• Change ActiveRecord version to >= 3.0
• Add .rb to generated migration file

[jhanggi]

👍 Can you rebase this PR into a couple discrete commits that explain the steps?

So removing the duplicate gem makes sense as a commit, as does adding the .rb (reference medihack#26) in that commit, and then the Rails other requirements into a commit so there isn't a back and forth. I trust your judgement to tell a good story.

[jhanggi]

And then once you're done with that and have this merged in, issue a PR against https://github.com/medihack/make_flaggable