-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce :user-valid
& :user-invalid
variants
#12370
Conversation
It looks like the pseudo elements are not yet added to https://github.com/cssnano/cssnano/blob/master/packages/postcss-merge-rules/src/lib/ensureCompatibility.js, because they are part of the Selectors Level 4 spec. Should I unmerge the rules in the test for now or should we wait for this feature to land until support is added in |
6b4dc07
to
d55fc3f
Compare
d55fc3f
to
9784aaa
Compare
Hey! You might have noticed that I forced pushed to this branch. The reason is because the PR now uses The code is ported as-is, so no API changes of your feature happened while moving it to the new codebase. I also made sure to add you as a co-author because you still deserve all the credit 💪 |
Hi @RobinMalfait! Is it possible to have it in v3, or it will only be available in v4? |
Any updates / timeline on this? Looking forward to these inputs! |
Yes, you can use arbitrary properties: |
9784aaa
to
7bd0851
Compare
Co-authored-by: Robin Malfait <[email protected]>
7bd0851
to
27aa8d6
Compare
(just rebased this PR) |
We use "custom" pseudo-element while waiting for Tailwind support: tailwindlabs/tailwindcss#12370
We use "custom" pseudo-element while waiting for Tailwind support: tailwindlabs/tailwindcss#12370
|
@MartijnCuppens Thank you for the PR! As you might have noticed from the other PRs we're only now starting to go through open PRs and features that haven't made the v4 cut. These new variants look great and we'll land them behind a feature flag for now. Our plan is to release them with 4.1 including updated docs but the feature will also be available right away in the Thank you for your patience here and sorry again for not being very responsive in the past. |
@@ -11,5 +11,6 @@ export default defineConfig({ | |||
}, | |||
define: { | |||
'process.env.NODE_ENV': '"production"', | |||
'process.env.FEATURES_ENV': '"stable"', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh smart 👍
See
Just landed in Chrome, Firefox & Safari: