Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan Next.js dynamic route segments with manual @source rules #16457

Merged
merged 5 commits into from
Feb 18, 2025

Conversation

philipp-spiess
Copy link
Member

@philipp-spiess philipp-spiess commented Feb 12, 2025

Part of #16287

Test plan

Added unit and integration tests

@philipp-spiess
Copy link
Member Author

Going to close this as it's an upstream issue. We can reopen if we decide to work around it from our side but if we can fix the upstream resource I'd expect this test to also live in the upstream tests.

@philipp-spiess philipp-spiess deleted the fix/next-dynamic-scanning branch February 17, 2025 14:48
@philipp-spiess philipp-spiess restored the fix/next-dynamic-scanning branch February 17, 2025 14:48
@philipp-spiess philipp-spiess force-pushed the fix/next-dynamic-scanning branch from bc4ef23 to 3e26640 Compare February 17, 2025 14:53
@philipp-spiess philipp-spiess marked this pull request as ready for review February 17, 2025 14:55
@philipp-spiess philipp-spiess requested a review from a team as a code owner February 17, 2025 14:55
Copy link
Member

@RobinMalfait RobinMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool that this is almost a drop-in replacement 💪

@philipp-spiess philipp-spiess merged commit 08972f2 into main Feb 18, 2025
5 checks passed
@philipp-spiess philipp-spiess deleted the fix/next-dynamic-scanning branch February 18, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants