Fix plugins with nested rules refering to the utility name #16539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
force-pushed
the
fix/plugin-with-nested-references-to-utility-name
branch
from
6d40a44 to
c80239f
Compare
thecrypticace
approved these changes
Feb 14, 2025
philipp-spiess
deleted the
fix/plugin-with-nested-references-to-utility-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes tailwindlabs/tailwindcss-typography#383
This PR fixes an issue that happened when JavaScript plugins create a nested rule that references to the utility name. The previous behavior looked like this:
I was able to come up with an approach that can be fixed entirely in the compat layer by leveraging the
rawfield on the candidate.Test plan
Added unit tests
Verified with the reproduction from Tailwind 4:
first-childresets formargin-topmissing when type scale is added with a breakpoint prefix tailwindcss-typography#383: