Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder includes in staging/sm #4379

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Reorder includes in staging/sm #4379

merged 1 commit into from
Jan 17, 2025

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Jan 16, 2025

Ref. #4376

@Ms2ger Ms2ger requested review from a team as code owners January 16, 2025 10:20
ptomato
ptomato approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course I didn't look at all 1.4k files, but LGTM once you make the linter happy. (The CI says there are a handful of these tests that include sm/non262.js while not using it.)

@Ms2ger Ms2ger force-pushed the non262-reverse-imports branch from e22ebd8 to dbe540a Compare January 17, 2025 10:11
@Ms2ger Ms2ger merged commit b0f03cb into main Jan 17, 2025
13 of 15 checks passed
@Ms2ger Ms2ger deleted the non262-reverse-imports branch January 17, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ms2ger @ptomato