feat(rpmbuild): update bash-completion handling #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add bash-completion as a recommended package. - Remove manual generation of bash completion files. - Update changelog to reflect these changes. Fixes tektoncd#264
tekton-robot
added
the
release-note
tekton-robot
added
size/XS
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
is there an issue with latest triggers? keep getting this issue in the integration tests (unrelated error): cc @tektoncd/triggers-maintainers |
|
/retest |
|
@chmouel naive question, how do we make sure "upstream" bash-completion is up-to-date with our version ? |
vdemeester
approved these changes
Jan 20, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
Ah just saw the issue, it's good. |
|
yeah i linked the wrong issue in my description, it fixes #2464 |
|
/retest |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since bash-completion now include _tkn we can add it as recommended and remove the generation
Fixes #2464
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes