Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make thumbprint a list, add defaults #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apanzerj
Copy link

@apanzerj apanzerj commented Nov 27, 2024

↪️ Pull Request

  • Make sure you are opening from a feature/feat/docs/fix/bug/hotfix/stable/chore (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry

📒 Description

Github asks that you put two thumbprints in the OIDC config, and the thumbprint itself should be a list, not a string, since you can add up to 5 thumbprints.

https://github.blog/changelog/2023-06-27-github-actions-update-on-oidc-integration-with-aws/

🕶️ Types of changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation
  • Dependencies

🤯 List of changes

Make thumbprint a list

👫 Relationships

🔎 Review hints

🚨 Test instructions

Checklist

  • [ x ] My code follows the code style of this project.
  • [ x ] I have read the CONTRIBUTING document.
  • [ x ] Added/updated unit tests for this change
  • [ x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).
  • [ x ] Filled out test instructions (In case there aren't any unit tests)
  • [ x ] I followed the existing code standards and didn't mess up the formatting.
  • [ x ] My change requires a change to the documentation.
  • [ x ] I did my best to add documentation to any public classes or methods I added.
  • [ x ] Included links to related issues/PRs

@apanzerj apanzerj changed the title Make thumbprint a list, add defaults Fix: Make thumbprint a list, add defaults Nov 27, 2024
@apanzerj apanzerj force-pushed the fix/allow_list_for_thumbprint branch from 4419dfa to 2f538fa Compare November 27, 2024 18:12
@apanzerj
Copy link
Author

tagging @ivankatliarchuk for review

@apanzerj apanzerj changed the title Fix: Make thumbprint a list, add defaults fix: Make thumbprint a list, add defaults Nov 27, 2024
@apanzerj
Copy link
Author

apanzerj commented Dec 9, 2024

@ivankatliarchuk bump. Just wondering if you have time to review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant