Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider registration actions should fire once or not at all when provider is inactive #2338

Open
wants to merge 5 commits into
base: release/T25.antman
Choose a base branch
from

Conversation

dpanta94
Copy link
Member

@dpanta94 dpanta94 commented Jan 6, 2025

🎫 Ticket

TCMN-178

🗒️ Description

Container would always fire registration actions of controllers for every time they would register and even if they were inactive.

As a result the following scenario would result in a fatal:

In ET -> Deactivate the main seating controller using a filter or const making the is_active method return false.
In ETP -> The main seating controller registers on the registration action of the ET's main seating controller.
We would have a fatal because the ET's main seating controller registration action would fire even when the controller is inactive.

🎥 Artifacts

Very low level change - making tests passing a valid artifact.

✔️ Checklist

  • Ran npm run changelog to add changelog file(s). More info here
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@dpanta94 dpanta94 marked this pull request as ready for review January 8, 2025 16:22
@dpanta94 dpanta94 force-pushed the fix/container-registration-actions branch from b1267da to b455ba8 Compare January 8, 2025 16:24
@dpanta94 dpanta94 changed the title Fix container registration actions to only fire once or not at all wh… Provider registration actions should fire once or not at all when provider is inactive Jan 8, 2025
@dpanta94 dpanta94 force-pushed the fix/container-registration-actions branch from 843d227 to bad3f74 Compare January 21, 2025 17:13
@dpanta94 dpanta94 changed the base branch from release/T25.imp to release/T25.antman January 21, 2025 17:14
@dpanta94 dpanta94 self-assigned this Jan 21, 2025
@dpanta94 dpanta94 added code review Status: requires a code review. needs tests Needs tests before merging. labels Jan 21, 2025
@dpanta94 dpanta94 removed the needs tests Needs tests before merging. label Jan 21, 2025
@dpanta94 dpanta94 requested a review from lucatume January 21, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review Status: requires a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants