Provider registration actions should fire once or not at all when provider is inactive #2338
+181
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
TCMN-178
🗒️ Description
Container would always fire registration actions of controllers for every time they would register and even if they were inactive.
As a result the following scenario would result in a fatal:
In ET -> Deactivate the main seating controller using a filter or const making the is_active method return false.
In ETP -> The main seating controller registers on the registration action of the ET's main seating controller.
We would have a fatal because the ET's main seating controller registration action would fire even when the controller is inactive.
🎥 Artifacts
Very low level change - making tests passing a valid artifact.
✔️ Checklist
npm run changelog
to add changelog file(s). More info herewpunit
orintegration
tests.wpunit
orintegration
tests.