Protecting input/output buffers of CH552 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehanj
changed the title
mchack-work
force-pushed
the
ch552_gpio
branch
from
c125118 to
7019cd9
Compare
mchack-work
approved these changes
Dec 7, 2023
| CH554UART1SendByte(Ep2Buffer[USBBufOutPoint++]); | ||
| recievedData[USBBufOutPoint] = Ep2Buffer[USBBufOutPoint]; | ||
| USBByteCount--; | ||
| memcpy(USB_output_buffer, Ep2Buffer, USBByteCount); |
There was a problem hiding this comment.
dehanj and I discussed wrapping this section inside USB_IE=0/USB_IE=1 to disable interrupts temporarily to protect Ep2Buffer and USBByteCount from being updated while we were copying data from it. It turns out that we're already answering NAK on USB at this time, so that's unneccessary. So it's OK by me to leave as is.
mchack-work
reviewed
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the issue that CH552 during certain circumstances can drop a bytes from UART -> USB.
Some other changes: