Add static analysis to CI #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchack-work
force-pushed
the
static-in-ci
branch
from
5f5ef45 to
e56b63c
Compare
|
Confirming by using tkey-builder:4 on main that it gives us the same checksum. So it is the changes in commit 76604fd "Silence Splint somewhat" that changes the checksum. |
- Exclude splint from CI, so we make another target for it "splint", which we might include in the "check" target later. - Move the analysis runs earlier in CI so they, including indentation checks, fail first. - Include printouts of hashen in check-binary-hashes to easier see what the digest are if it fails in CI.
The only real changes are some unitialized variables and that we now make explicit that we don't care about the return value from memset().
dehanj
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run at least make check in CI. Related to #176
Depends on #191 to include tools in tkey-builder and a new tkey-builder image in ghcr.