-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding explanation and changing name of personalize.py #189
Conversation
6ee9a55
to
d97f27f
Compare
I prefer the old name (though not the description in the hader). The use case is to create a unique TKey (i.e. personalize it) by generating unique UDS and UDI. Patching is just how these unique fields are put into the design. I have no problem with tools that have names longer than three letters. 'personalize_uds_udi.py', 'gen_unique_tkey.py' 'gen_udi_uds.py' are some ideas of names that reflect what the tool does. |
While I agree, I also disagree with the use case you mention. The use case of this particular script is to simply patch your already personalized (hopefully) UDS or UDI. To personalize your UDS and UDI your are using tpt.py, (Tillitis Provisioning Tool), and this tool to actually put it in the bitstream - so a both of them achieves a personalization according to me. Or you simpy update the uds.hex and udi.hex by yourself. So I actually think it is a bit misleading and might give false hopes that all you need to do to get a unique UDS and UDI is to run this tool, which is not true. |
Ah, I'm mixing up tpt with personalize.py. Then i totally agree with the new name. |
I think the changes look good, but suggest we squash all the commits. |
6834b7c
to
bf9171f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like more explanation of how it all fits together but might not need it here.
Tested building. Works fine.
Also adding a more detailed explaination of what the script intends to do
bf9171f
to
c85b531
Compare
Changed filename in order to be a bit less cryptic about what the python script does.
Also adding a more detailed explanation about what it intends to do.