Fix flash target in contrib/Makefile #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthornblad
approved these changes
Oct 11, 2024
Setting the working directory to a directory that exist. Previously the working directory was set to /build/hw/application_fpga. But that path does not exist since hw/application_fpga was mounted to /build. Thus resulting in an error: 'Error: workdir "/build/hw/application_fpga" does not exist on container'
agren
force-pushed
the
fix_flash_make_target
branch
from
b7d1c75 to
a32ecad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue with running
make -C contrib flash(Command found in the dev guide). The command exits with the following error:Error: workdir "/build/hw/application_fpga" does not exist on containerFixed by setting the working directory to /build.
Previously the working directory was set to
/build/hw/application_fpga. But that path does not exist sincehw/application_fpgais already mounted to/build. Thus resulting in an error.Type of change
Submission checklist