Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fw: Fix erroneous type in frame header #270

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fw: Fix erroneous type in frame header #270

merged 1 commit into from
Oct 11, 2024

Conversation

dehanj
Copy link
Member

@dehanj dehanj commented Oct 9, 2024

Description

The frame_header has the wrong type in the struct. It is not used as the enum, it is used for the actual length.

This does note seem to change the actual binary output, but I would still argue it should be the type size_t.
As it is in tkey-libs.

Type of change

Please tick any that are relevant to this PR and remove any that aren't.

  • Bugfix (non breaking change which resolve an issue)

Submission checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my changes
  • I have tested and verified my changes on target
  • My changes are well written and CI is passing
  • I have squashed my work to relevant commits and rebased on main for linear history
  • I have updated the documentation where relevant (readme, dev.tillitis.se etc.)

@dehanj dehanj merged commit f133665 into main Oct 11, 2024
5 checks passed
@dehanj dehanj deleted the fix-wrong-type branch October 11, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants