Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix testbench for tk1 #271

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Fix testbench for tk1 #271

merged 3 commits into from
Oct 11, 2024

Conversation

dehanj
Copy link
Member

@dehanj dehanj commented Oct 10, 2024 •
edited
Loading

Description

  • Add clean target for the testbench generated files
  • Add it so it always cleans in contrib/Makfile
  • Fix broken tk1 testbench after name change

Testbenches are not running in CI yet, so run it manually using make tb in hw/application_fpga or make run-tb in contrib.

FYI: the testbench for uds_rom is already broken, see: #260

Type of change

Please tick any that are relevant to this PR and remove any that aren't.

  • Bugfix (non breaking change which resolve an issue)

Submission checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my changes
  • I have tested and verified my changes on target
  • My changes are well written and CI is passing
  • I have squashed my work to relevant commits and rebased on main for linear history
  • I have updated the documentation where relevant (readme, dev.tillitis.se etc.)

@dehanj dehanj changed the title Fix tb Fix testbench for tk1 Oct 10, 2024
@dehanj dehanj marked this pull request as ready for review October 10, 2024 11:10
@dehanj dehanj mentioned this pull request Oct 10, 2024
Merged
11 tasks
@dehanj dehanj mentioned this pull request Oct 11, 2024
Merged
1 task
dehanj added 3 commits October 11, 2024 15:50
@dehanj
Add make target to clean testbench files
056ee4d 
Add it as default in the contrib Makefile.
@dehanj
tb: fix tk1 testbench after name change
d9d4181 
This issue was introduced in commit 53c5e70, after name change of RAM
randomization API.
@dehanj
Doc: fix typo in tk1 core readme
cbb2ba7
@dehanj dehanj merged commit cbb2ba7 into main Oct 11, 2024
5 checks passed
@dehanj dehanj deleted the fix_tb branch October 11, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jthornblad jthornblad jthornblad approved these changes

@mchack-work mchack-work Awaiting requested review from mchack-work

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dehanj @jthornblad