Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add place and route script #282

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Add place and route script #282

merged 1 commit into from
Oct 24, 2024

Conversation

jthornblad
Copy link
Contributor

Description

Run multiple threads of nextpnr-ice40 to find a seed that gives a layout that meets timing.

Type of change

Please tick any that are relevant to this PR and remove any that aren't.

  • Bugfix (non breaking change which resolve an issue)
  • Feature (non breaking change which adds functionality)
  • Breaking Change (a change which would cause existing functionality to not work as expected)
  • Documentation (a change to documentation)

Submission checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my changes
  • I have tested and verified my changes on target
  • My changes are well written and CI is passing
  • I have squashed my work to relevant commits and rebased on main for linear history
  • I have added a "Co-authored-by: x" if several people contributed, either pair programming or by squashing commits from different authors.
  • I have updated the documentation where relevant (readme, dev.tillitis.se etc.)
  • QEMU is updated to reflect changes

@jthornblad jthornblad force-pushed the add_place_n_route_script branch from 6a38c8b to 4488e11 Compare October 22, 2024 07:52
@dehanj
Copy link
Member

dehanj commented Oct 22, 2024

Nice work, have not tested it yet - but maybe this should be in the tools folder? hw/application_fpga/tools is where we have other scripts or tools that we use

@jthornblad jthornblad changed the title Add Place-N-Route script Add place and route script Oct 22, 2024
@jthornblad jthornblad force-pushed the add_place_n_route_script branch from 4488e11 to 49a6b97 Compare October 22, 2024 12:22
Run multiple threads of nextpnr-ice40 to find a seed that gives a
layout that meets timing.
@jthornblad jthornblad force-pushed the add_place_n_route_script branch from 49a6b97 to c6e8b69 Compare October 22, 2024 13:20
@jthornblad
Copy link
Contributor Author

Done

@jthornblad jthornblad marked this pull request as ready for review October 23, 2024 09:22
Copy link
Member

@dehanj dehanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good enough.

Some minor comments but not blocking in my opinion:

  • It says "Set target frequency for design in MHz (might be overridden from value in synthesis file)". I wonder when this is not overridden? When I test it does not matter, it always get overridden by the synth.json. Should the comment say that it should be the same as was used when the synth.json was built?

@dehanj
Copy link
Member

dehanj commented Oct 24, 2024

Can also verify that I managed to run the script, get a valid seed to achieve 24 Mhz, then put it in the Makefile and it still gives the same result.

The seed that worked for me 4086954404853248473, it gave 24.19 MHz.

@dehanj dehanj merged commit c6e8b69 into main Oct 24, 2024
5 checks passed
@dehanj dehanj deleted the add_place_n_route_script branch October 24, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants