Fix caching the branches #1842
Merged
Fix caching the branches #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We unconditionally cache the result of the `for-each-ref` call as `branches` in the store although the function is parameterized and the user can specify which `refs` she wants. We generally want the defaults refs, "refs/heads" and "refs/remotes", in the cache as the status view relies on it. Update the store as good as possible. For more esoteric values of `refs` just skip caching altogether to keep it simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We unconditionally cache the result of the
for-each-refcall asbranchesin the store although the function is parameterized and the user can specify whichrefsshe wants.We generally want the defaults refs, "refs/heads" and "refs/remotes", in the cache as the status view relies on it. Update the store as good as possible. For more esoteric values of
refsjust skip caching altogether to keep it simpler.