🚏 Blogs to App Router #2722
Open
🚏 Blogs to App Router #2722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Calinator444
requested changes
Jan 19, 2025
Comment on lines
24
to
28
| <> | ||
| <DefaultSeo openGraph={{ url: 'https://tina.io' + router.asPath }} /> | ||
| <DefaultSeo openGraph={{ url: 'https://tina.io' + pathname }} /> | ||
| <Layout sticky={false}> | ||
| <DocsLayoutGrid> | ||
| <Sidebar> |
There was a problem hiding this comment.
I don't know much about you you guys populate metadata on your pages but there's a few SEO props that are visible on the live page that aren't there on the staging branch. I'd double check your configuration
Figure: SEO props on 'tina.io/blog' that are not there in staging
There was a problem hiding this comment.
Added them back 👍
Figure: Local showing blog SEO correctly
There was a problem hiding this comment.
I'm still not seeing the googlebot tag in staging. I can see it on other staging URLS so it seems to be related to this branch
Co-authored-by: Caleb Williams [SSW] <[email protected]>
Co-authored-by: Caleb Williams [SSW] <[email protected]>
|
Your 404 page still seems to be returning a 500 level error in staging
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #2555 we have moved the blogs routes to the app router
Not many changes to the actual logic, i've introduced some extra utility functions such like
extractTextFromBodyand extrapolatedformatDateto be used amongst docs and blogs.Removed alot of styled jsx which is a double whammy because we want to move away from using this 👍