Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goenv: parse patch version, add func Compare to compare two Go version strings #4536

Merged
merged 5 commits into from
Oct 21, 2024
Merged

goenv: parse patch version, add func Compare to compare two Go version strings #4536

merged 5 commits into from
Oct 21, 2024

Conversation

ydnar
Copy link
Contributor

@ydnar ydnar commented Oct 19, 2024 •
edited
Loading

This PR implements 3 changes:

Extracted from #4501.

@ydnar ydnar requested review from deadprogram and aykevl October 19, 2024 20:03
@ydnar ydnar self-assigned this Oct 19, 2024
@ydnar ydnar changed the base branch from release to dev October 19, 2024 20:03
@ydnar ydnar mentioned this pull request Oct 19, 2024
Merged
aykevl
aykevl approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@aykevl aykevl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Was this intended to be kept as separate commits or can this be squashed when merging?

@deadprogram
Copy link
Member

I think we can squash it, and keep this moving along.

Thank you very much @ydnar for the fixes/improvements and to @aykevl for review. Now merging

@deadprogram deadprogram merged commit a191326 into tinygo-org:dev Oct 21, 2024
17 checks passed
@ydnar
Copy link
Contributor Author

ydnar commented Oct 21, 2024

LGTM.

Was this intended to be kept as separate commits or can this be squashed when merging?

Squashed!

Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aykevl aykevl aykevl approved these changes

@deadprogram deadprogram Awaiting requested review from deadprogram

Assignees

@ydnar ydnar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ydnar @deadprogram @aykevl