Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Randomize order of GIFs and add random category #24

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Randomize order of GIFs and add random category #24

merged 1 commit into from
Apr 6, 2023

Conversation

tomgroenwoldt
Copy link
Owner

This solves part of #22.

The PR adds a random category and randomizes the order of GIFs in each category.

@tomgroenwoldt tomgroenwoldt added the enhancement New feature or request label Apr 5, 2023
@tomgroenwoldt tomgroenwoldt self-assigned this Apr 5, 2023
@tomgroenwoldt
Copy link
Owner Author

This adds some things I'm not happy about, I will refactor this in another PR.

Things I dislike about this:

  • AppState in match statement in the update function
  • The check for unplayed GIFs to end the application. This should be checked somewhere else

@tomgroenwoldt tomgroenwoldt merged commit 6beb38c into master Apr 6, 2023
@tomgroenwoldt tomgroenwoldt deleted the randomize-order-and-add-random-mode branch April 6, 2023 00:02
@tomgroenwoldt tomgroenwoldt mentioned this pull request Apr 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tomgroenwoldt tomgroenwoldt

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomgroenwoldt