Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pd 4288/stack upgrade #30

Merged
merged 17 commits into from
Jan 20, 2025
Merged

Pd 4288/stack upgrade #30

merged 17 commits into from
Jan 20, 2025

Conversation

hieu-w
Copy link
Contributor

@hieu-w hieu-w commented Jan 2, 2025 •
edited
Loading

Motivation and Context

Jira Link:
https://toruslabs.atlassian.net/browse/PD-4288

Description

Upgrade stacks:

  • Update deps
  • Migrate ESlint9 flat config
  • Drop node 18 support, from 20

How has this been tested?

  • CI script run when push commit
  • npm run test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@hieu-w hieu-w requested a review from chaitanyapotti January 3, 2025 11:30
@hieu-w hieu-w self-assigned this Jan 3, 2025
chaitanyapotti
chaitanyapotti approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 02f9fdb into master Jan 20, 2025
3 checks passed
@chaitanyapotti chaitanyapotti deleted the PD-4288/Stack-upgrade- branch January 20, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

Assignees

@hieu-w hieu-w

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hieu-w @chaitanyapotti