Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change NHS API to update with both systems' coordinates #5

Merged
merged 11 commits into from
May 13, 2024

Conversation

efaulhaber
Copy link
Member

@efaulhaber efaulhaber commented May 6, 2024

With this PR, I pass both system's coordinates to the NHS, together with the information which of the coordinates are changing and which are static. The NHS can then decide if and what to update.

For example, the grid NHS doesn't need to update for fluid-boundary NHS. A neighborhood search that explicitly computes the neighbor lists will have to update them because the fluid particles are moving.

@efaulhaber efaulhaber changed the title Apply https://github.com/trixi-framework/TrixiParticles.jl/pull/518 Apply TrixiParticles.jl#518 May 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

Attention: Patch coverage is 27.77778% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 74.86%. Comparing base (ce24fd3) to head (f59c553).

❗ Current head f59c553 differs from pull request most recent head be5991a. Consider uploading reports for the commit be5991a to get more accurate results

Files Patch % Lines
src/grid_nhs.jl 33.33% 10 Missing ⚠️
src/trivial_nhs.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   75.66%   74.86%   -0.80%     
==========================================
  Files           7        7              
  Lines         189      191       +2     
==========================================
  Hits          143      143              
- Misses         46       48       +2     
Flag Coverage Δ
unit 74.86% <27.77%> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efaulhaber efaulhaber changed the title Apply TrixiParticles.jl#518 Change NHS API to update with both systems' coordinates May 6, 2024
@efaulhaber efaulhaber requested a review from LasNikas May 10, 2024 06:24
@efaulhaber efaulhaber requested a review from svchb May 10, 2024 09:19
@efaulhaber efaulhaber added the breaking changes This change will break the public API and requires a new major release label May 11, 2024
@efaulhaber efaulhaber mentioned this pull request May 12, 2024
Copy link
Collaborator

@LasNikas LasNikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@efaulhaber efaulhaber enabled auto-merge (squash) May 13, 2024 08:42
@efaulhaber efaulhaber merged commit 540505f into main May 13, 2024
8 checks passed
@efaulhaber efaulhaber deleted the ef/trixiparticles-518 branch May 13, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes This change will break the public API and requires a new major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants