Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove redundant parameter values #8

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

YasiruR
Copy link

@YasiruR YasiruR commented Jan 11, 2025

This PR fixes #7

Changes (text_logger):

  • removed logging empty params
  • append-based log entry construction

Benchmark result comparison:
comparison

Refer to the following csv files for complete results:
previous_results.csv
new_results.csv

* wip rm empty params

* rm .idea

* added benchmark results

* rm .idea

* fixed import paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant parameter values
1 participant