Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare to other libs #13

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

jeromekelleher
Copy link
Member

WIP

Notes:

  1. Biopython is slow
  2. The phangorm method is really very quick, but uses a lot of memory. Not quite sure what it's doing yet.
  3. I really hate trying to program in R

@jeromekelleher jeromekelleher marked this pull request as draft August 27, 2021 14:13
@petrelharp
Copy link

I really hate trying to program in R

I love R but hate the phylogenetics packages. That said, feel free to give me some R-related tasks.

@petrelharp
Copy link

petrelharp commented Aug 27, 2021

A tough competitor would probably be castor (source code here):
Screenshot from 2021-08-27 08-08-42
The author is here, so I could ask for assistance if we want. I'm not sure if it does the things we want to compare to, though? Some things it does in the overlap are: count_tips_per_node; find_farthest_tip_pair; get_all_distances_to_root; get_mrca_of_set; get_pairwise_mrcas; hsp_max_parsimony; asr_max_parsimony.

@jeromekelleher
Copy link
Member Author

Very interesting, thanks @petrelharp. It would be good to try this out - I'll created issue #14 to track.

@jeromekelleher jeromekelleher marked this pull request as ready for review August 27, 2021 18:48
@jeromekelleher jeromekelleher merged commit ed7ad86 into tskit-dev:main Aug 27, 2021
@jeromekelleher jeromekelleher deleted the compare-other-libs branch August 27, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants