change handle_io_async return type to void #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return value is never checked. Invocations of handle_io_async are expected to call ublksrv_complete_io even in an error occurred, so it's cleaner if that responsibility stays with the target in every case. Returning void also matches the similar function `submit_bio()` in the kernel.
|
->handle_io_async is part of libublksrv interface(ABI), and we can't change its type any more, otherwise it may break existed external applications. But we can document the point that the return value is ignored by libublksrv, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return value is never checked. Invocations of handle_io_async are expected to call ublksrv_complete_io even in an error occurred, so it's cleaner if that responsibility stays with the target in every case.
Returning void also matches the similar function
submit_bio()in the kernel.Fixes #81