Skip to content

Commit

Permalink
🐛compatible with vConsole who will wrap global variables with proxy (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
kuitos authored Aug 23, 2023
1 parent afb92ed commit 7328396
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions src/sandbox/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,13 @@ export function getTargetValue(target: any, value: any): any {

const boundValue = Function.prototype.bind.call(value, target);

// some callable function has custom fields, we need to copy the enumerable props to boundValue. such as moment function.
// use for..in rather than Object.keys.forEach for performance reason
// eslint-disable-next-line guard-for-in,no-restricted-syntax
for (const key in value) {
boundValue[key] = value[key];
}
// some callable function has custom fields, we need to copy the own props to boundValue. such as moment function.
Object.getOwnPropertyNames(value).forEach((key) => {
// boundValue might be a proxy, we need to check the key whether exist in it
if (!boundValue.hasOwnProperty(key)) {
Object.defineProperty(boundValue, key, Object.getOwnPropertyDescriptor(value, key)!);
}
});

// copy prototype if bound function not have but target one have
// as prototype is non-enumerable mostly, we need to copy it from target function manually
Expand Down

1 comment on commit 7328396

@vercel
Copy link

@vercel vercel bot commented on 7328396 Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.