CLDR-18080 add Hant-Latn transform, add Hans-Latn alias for Hani-Latn #4295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedberg-icu
force-pushed
the
CLDR-18080-add-Hant-Latn-transform-and-adjust-Hani-Latn
branch
from
70dd582 to
2a08662
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
| # Convert compounds; these are added individually, not derived from Unihan kMandarin. | ||
| # Here Han-Spacedhan() has not yet been applied. | ||
| # The following was moved from Hans-Latn; in a Hant/Taiwan context, the simplified-form city name 沈阳 should still transform to shěnyáng. | ||
| 沈 } 阳 →shěn;# 沈 is shěn (not chén) if followed by 阳 yáng: 沈阳 city Shěnyáng |
There was a problem hiding this comment.
Hans-Latn also matched 沈 阳, but this only matches 沈阳 without a space; is this intended?
There was a problem hiding this comment.
@robertbastian @srl295 I think the behavior for the new Hant is more correct, we should fix (under a different PR) Hans-Latn to do the Han-SpacedHan after handling the compounds. Filed a ticket: https://unicode-org.atlassian.net/browse/CLDR-18254
srl295
approved these changes
Jan 22, 2025
| [苧]→zhù; # U+82E7 | ||
| # END From Unicode 17, the above should be autogenerated: | ||
| # Then run the normal Hani-Latn transform for the rest | ||
| ::Hani-Latn(); |
pedberg-icu
deleted the
CLDR-18080-add-Hant-Latn-transform-and-adjust-Hani-Latn
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-18080
This ticket adds a
Hant-Latntransform which uses 101 readings that are different for Hant/TW, then calls the mainHani-Latntransform for everything else. It also addsHans-Latnas an alias for the currentHani-Latntransform, and adds test data for both. Also, as noted in the ticket:沈 } \u0020? 阳 ->shěn;# 沈 is shěn (not chén) if followed by 阳 yáng: 沈阳 city Shěnyáng; this dates from before Unicode 14, at which point the kMandarin value for U+6C88 沈 was changed from “chén” to “shěn chén”. With that change the rule became obsolete forHans. However it is still slightly relevant forHant; if the simplified form 沈阳 of the name for the city Shenyang is encountered in a Hant/Taiwan context, the first character should be transliterated as shěn rather than as chén. So this rule should be moved to theHant-Latntransform.ALLOW_MANY_COMMITS=true