CLDR-18128 Generate datetime test data using semantic skeletons #4313
+3,342
−112,001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… core test set / kernel
… date/time as a String
…include semantic skeletons
sffc
approved these changes
Jan 26, 2025
There was a problem hiding this comment.
Nice work!
What I think we have left before we consider the ticket "complete":
- Optimize the kernel a bit more to further reduce duplication in test case generation
- Including support for TimePrecision
- Take the cartesian product of the kernel over all of the dimensions
- Fix TODOs and any additional bugs we find
What we currently have is a great milestone, sufficient for ICU4X testing and CLDR 47.
macchiati
approved these changes
Jan 26, 2025
|
@echeran Ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-18128
This PR switches the implementation of date time test data generation to:
A follow up PR is still needed to use this kernel set of combinations and combine it via iteration over all values in the dimensions of: locales, a larger set of input date/times, a larger set of time zones, etc. Combining this kernel set as a Cartesian product with iterations of larger value sets across different dimensions will ensure representation of those values in the different dimensions.
ALLOW_MANY_COMMITS=true