CLDR-18267 site: document how to handle known issues #4324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srl295
requested review from
macchiati,
AEApple,
btangmu,
pedberg-icu and
DraganBesevic
|
✨ deployed to https://f7322509.cldr.pages.dev |
macchiati
previously approved these changes
Jan 30, 2025
|
|
||
| See [Testing!](/development/development-process/#testing) for more details on how this is used during development. | ||
|
|
||
| For this BRS task there are two goals. FIRST, make sure that any log known issue targets that are remaining issues, point to a currently open ticket. SECOND, make sure that any issues that actually were fixed, have the "logKnownIssue" call removed to make sure the regression tests are actually run. |
There was a problem hiding this comment.
For the future, linebreak between sentences: https://sembr.org/
AEApple
reviewed
Jan 30, 2025
| @@ -96,7 +96,10 @@ When a ticket is in design, the owner is responsible for bringing back to the co | |||
|
|
|||
| Skipping test failures | |||
|
|
|||
| If there is a test failure that is due to a bug that cannot be fixed right now (eg it requires a data change, but it is past the data freeze), then use the logKnownIssue() method to disable the test. See http://site.icu-project.org/setup/eclipse/time for details, and look in the CLDR test code for some examples of usage. | |||
| If there is a test failure that is due to a bug that cannot be fixed right now (eg it requires a data change, but it is past the data freeze), then use the logKnownIssue() method to disable the test. See <https://icu.unicode.org/setup/eclipse/time> for details, and look in the CLDR test code for some examples of usage. | |||
There was a problem hiding this comment.
Question about the 'but it is past the data freeze'. I think we need to be more specific here, since we can make changes after the data freeze for issues during alpha & beta if the CLDR TC and the ICU TC agree.
There was a problem hiding this comment.
Maybe something like: 'when it is past the data freeze and the CLDR TC considers it too risk or not a priority to fix in the current release'.
|
✨ deployed to https://f6ae1242.cldr.pages.dev |
pedberg-icu
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-18267
see #4322 for the current known issues PR
ALLOW_MANY_COMMITS=true