Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-18091 Add Mexican and Guatemalan languageMatch distances in languageInfo.xml #4331

Closed
wants to merge 1 commit into from
Closed

CLDR-18091 Add Mexican and Guatemalan languageMatch distances in languageInfo.xml #4331

wants to merge 1 commit into from

Conversation

MarcAbonce
Copy link

CLDR-18091

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@MarcAbonce MarcAbonce changed the title CLDR 18091: Add Mexican and Guatemalan languageMatch distances in languageInfo.xml CLDR-18091: Add Mexican and Guatemalan languageMatch distances in languageInfo.xml Feb 3, 2025
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@MarcAbonce MarcAbonce changed the title CLDR-18091: Add Mexican and Guatemalan languageMatch distances in languageInfo.xml CLDR-18091 Add Mexican and Guatemalan languageMatch distances in languageInfo.xml Feb 3, 2025
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • common/supplemental/languageInfo.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

macchiati
macchiati requested changes Feb 9, 2025
View reviewed changes
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added comments in the ticket, so I'd like to pause this until that's resolved.

@MarcAbonce
Copy link
Author

Based on the conversation in Jira, I'm going to close this PR.

Note, in case anyone stumbles upon this PR in the future:
These fallbacks can be inferred through likelySubtags.xml.
So if I get yua locale, I can infer a fallback through yua → yua_Latn_MX, then crop it to und_MX (or und_Script_Territory in some cases) and then to es_Latn_MX.

@MarcAbonce MarcAbonce closed this Feb 10, 2025
@MarcAbonce MarcAbonce deleted the cldr-18091 branch February 10, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macchiati macchiati macchiati requested changes

Assignees

@MarcAbonce MarcAbonce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcAbonce @macchiati