CLDR-18133 supplemental currency needs to be @ORDERED

[srl295]

CLDR-18133

• also fix a SPEC typo- @ORDERED applies to this element, not to children.

• This PR completes the ticket.

ALLOW_MANY_COMMITS=true

[srl295]

This doesn't fix the JSON issue, but it was discovered while working on it…

[srl295]

Something's wrong, because CLDRFile with a DTDComparator is returning lexical instead of file order.

//supplementalData/currencyData/region[@iso3166="BY"]/currency[@iso4217="BYB"][@from="1994-08-01"][@to="2000-12-31"]
//supplementalData/currencyData/region[@iso3166="BY"]/currency[@iso4217="BYN"][@from="2016-07-01"]
//supplementalData/currencyData/region[@iso3166="BY"]/currency[@iso4217="BYR"][@from="2000-01-01"][@to="2017-01-01"]
//supplementalData/currencyData/region[@iso3166="BY"]/currency[@iso4217="RUR"][@from="1991-12-25"][@to="1994-11-08"]
//supplementalData/currencyData/region[@iso3166="BY"]/currency[@iso4217="SUR"][@from="1961-01-01"][@to="1991-12-25"]

Should be:

• BYN
• BYR
• BYB
• RUR
• SUR

[jira-pull-request-webhook]

Notice: the branch changed across the force-push!

• common/dtd/ldmlSupplemental.dtd is different
• docs/ldml/tr35.md is now changed in the branch
• tools/cldr-code/src/test/java/org/unicode/cldr/util/TestCLDRFile.java is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

[srl295]

OK. I fixed the DTD and added a test.

I'll fix the JSON in a followon PR.

[srl295]

FYI this did fix the JSON data- but only when the dtd is also copied into cldr-staging, since the json converter uses CLDR_DIR of cldr-staging.

[macchiati]

Good! Using the cldr staging version seems fragile, unless there is a test that it matches head of cldr

…

On Thu, Feb 6, 2025, 07:40 Steven R. Loomis ***@***.***> wrote: FYI this *did* fix the JSON data- but only when the dtd is also copied into cldr-staging, since the json converter uses CLDR_DIR of cldr-staging. — Reply to this email directly, view it on GitHub <#4344 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACJLEMHH2FBWLIFZ64XQVFT2ON67TAVCNFSM6AAAAABWSCQ2MSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBQGE3TMOJYHE> . You are receiving this because your review was requested.Message ID: ***@***.***>

[srl295]

Good! Using the cldr staging version seems fragile, unless there is a test that it matches head of cldr

It's actually correct here. Because the CLDR_DIR is pointing at, say, release-47-beta3 etc. So cldr staging is the correct place for the DTD.

My problem is that I was changing the CLDR tooling at the same time. If I was patching the data, I would have had to run GenerateProductionData for example.

[macchiati]

Makes sense. I'm just wondering how we can make sure that other people don't stumble over this problem in the future.

…

On Thu, Feb 6, 2025, 09:49 Steven R. Loomis ***@***.***> wrote: Good! Using the cldr staging version seems fragile, unless there is a test that it matches head of cldr It's actually correct here. Because the CLDR_DIR is pointing at, say, release-47-beta3 etc. So cldr staging is the correct place for the DTD. My problem is that I was changing the CLDR *tooling* at the same time. If I was patching the data, I would have had to run GenerateProductionData for example. — Reply to this email directly, view it on GitHub <#4344 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACJLEMDG7QBIA2MW3GBNOD32OOOCLAVCNFSM6AAAAABWSCQ2MSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBQGU4DCNZVGY> . You are receiving this because your review was requested.Message ID: ***@***.***>

[srl295]

Makes sense. I'm just wondering how we can make sure that other people don't stumble over this problem in the future.

automating GenerateProductionData is probably the best way.

[macchiati]

Makes sense.

…

On Mon, Feb 10, 2025 at 9:36 AM Steven R. Loomis ***@***.***> wrote: Makes sense. I'm just wondering how we can make sure that other people don't stumble over this problem in the future. automating GenerateProductionData is probably the best way. — Reply to this email directly, view it on GitHub <#4344 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACJLEMCXLCCSMII3WVHJFSL2PDPRBAVCNFSM6AAAAABWSCQ2MSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBYG43TCNJWGM> . You are receiving this because your review was requested.Message ID: ***@***.***>