CLDR-18128 Pair classical with semantic skeletons in datetime test data #4348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macchiati
previously approved these changes
Feb 6, 2025
sffc
previously approved these changes
Feb 6, 2025
echeran
force-pushed
the
testdata-gen-datetime-classical-skel-with-sem
branch
from
fb79ac4 to
d36dbc9
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
Just need a rubber stamp now after applying the formatter changes and needing to pull in the latest from |
macchiati
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-18128
This PR is another update to the datetime test data generation that support semantic skeletons, introduced in #4313. (A previous recent followup update PR was #4341)
The purpose of this PR's update is to include the "classical" skeleton string in test cases whenever the semantic skeleton is used as input. The reason is that i18n implementations like ICU don't have support for such a new concept as semantic skeletons. However, they can still format regular "classical" skeletons in order to execute the test case and verify the expected formatted output string is correct.
ALLOW_MANY_COMMITS=true