Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17971 kbd: (dtd/spec) add <info attribution=…> attribute #4360

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Feb 11, 2025

  • and example files

CLDR-17971

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295
Copy link
Member Author

srl295 commented Feb 11, 2025

Review note: kbd-check will fail here until the tooling catches up with unreleased version v47. please ignore.

mcdurdin
mcdurdin previously approved these changes Feb 12, 2025
@miloush
Copy link
Contributor

miloush commented Feb 12, 2025

Like I mentioned at the meeting, I am not keen on saying the "attribution" attribute is to be used for "reference" purposes, which is a semantic piece of metadata. Attribution can also sound like endorsement. I am fine with adding "attribution" attribute that lists contributors, but if we want to include an information about which standard is the layout based on, maybe we could have "basedOn" attribute or "reference" or similar.

If the usage of the attribute written in this PR is what you are going for, then it should be called something else like "reference". If the name of the attribute in this PR is what you are going for (and I have no objections to adding it), then the usage text should be rewritten to indicate it is meant for attribution, not source standards.

@srl295
Copy link
Member Author

srl295 commented Feb 12, 2025

Like I mentioned at the meeting, I am not keen on saying the "attribution" attribute is to be used for "reference" purposes, which is a semantic piece of metadata. Attribution can also sound like endorsement. I am fine with adding "attribution" attribute that lists contributors, but if we want to include an information about which standard is the layout based on, maybe we could have "basedOn" attribute or "reference" or similar.

If the usage of the attribute written in this PR is what you are going for, then it should be called something else like "reference". If the name of the attribute in this PR is what you are going for (and I have no objections to adding it), then the usage text should be rewritten to indicate it is meant for attribution, not source standards.

A full semantic model might be something more like OCI annotations https://specs.opencontainers.org/image-spec/annotations/#pre-defined-annotation-keys - we could have key-value pairs for additional data. I think what you are saying is that attribution="Malta Standards Authority" (typo in the file, i'll update) rather than having the standard number there.

- attribution is an entity name only.
@srl295
Copy link
Member Author

srl295 commented Feb 12, 2025

@miloush the standards name is more appropriate as part of the keyboard name

@srl295 srl295 requested a review from mcdurdin February 12, 2025 14:34
@srl295
Copy link
Member Author

srl295 commented Feb 18, 2025

@miloush you said you were OK with the current formulation?

@miloush
Copy link
Contributor

miloush commented Feb 18, 2025

I am OK with the attribute but the description in the spec is the opposite of what we agreed, isn't it?

update per review feedback
@srl295
Copy link
Member Author

srl295 commented Feb 18, 2025

I am OK with the attribute but the description in the spec is the opposite of what we agreed, isn't it?

Does this capture it now? Or can you suggest a change?

@srl295
Copy link
Member Author

srl295 commented Feb 20, 2025

@unicode-org/cldr-keyboards ping? can i get a review on this?

Copy link
Contributor

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srl295 srl295 merged commit b8c65c4 into unicode-org:main Feb 21, 2025
9 of 10 checks passed
@srl295 srl295 deleted the cldr-17971/kbd-attribution branch February 21, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants