-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-17971 kbd: (dtd/spec) add <info attribution=…> attribute #4360
Conversation
- and example files
Review note: kbd-check will fail here until the tooling catches up with unreleased version v47. please ignore. |
Like I mentioned at the meeting, I am not keen on saying the "attribution" attribute is to be used for "reference" purposes, which is a semantic piece of metadata. Attribution can also sound like endorsement. I am fine with adding "attribution" attribute that lists contributors, but if we want to include an information about which standard is the layout based on, maybe we could have "basedOn" attribute or "reference" or similar. If the usage of the attribute written in this PR is what you are going for, then it should be called something else like "reference". If the name of the attribute in this PR is what you are going for (and I have no objections to adding it), then the usage text should be rewritten to indicate it is meant for attribution, not source standards. |
A full semantic model might be something more like OCI annotations https://specs.opencontainers.org/image-spec/annotations/#pre-defined-annotation-keys - we could have key-value pairs for additional data. I think what you are saying is that |
- attribution is an entity name only.
@miloush the standards name is more appropriate as part of the keyboard name |
@miloush you said you were OK with the current formulation? |
I am OK with the attribute but the description in the spec is the opposite of what we agreed, isn't it? |
update per review feedback
Does this capture it now? Or can you suggest a change? |
@unicode-org/cldr-keyboards ping? can i get a review on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CLDR-17971
ALLOW_MANY_COMMITS=true