Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-18294 Fix known issue to reference future ticket #4370

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

btangmu
Copy link
Member

@btangmu btangmu commented Feb 12, 2025

CLDR-18294

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@btangmu
Copy link
Member Author

btangmu commented Feb 12, 2025

The previous PR also had a possible performance issue. @macchiati had written "Note: I suspect that it is best if we piggy back off of an existing related test that cycles of all locales and all paths. Otherwise we might get churn as locales are tossed out of the cache and then rebuilt from disk."

I called checkNullWithInheritanceMark from TestAllLocales but that doesn't address the performance issue well. I haven't measured the time. I can follow up on that, either in this ticket or the new v48 ticket

@macchiati
Copy link
Member

"Note: I suspect that it is best if we piggy back off of an existing related test that cycles of all locales and all paths. Otherwise we might get churn as locales are tossed out of the cache and then rebuilt from disk."

That's for the future, because it is already widespread; this test only adds a slight increment to that (if indeed it is an issue; as you say, we have to measure first)

@macchiati
Copy link
Member

Taking the liberty of merging in the interests of time.

@macchiati macchiati merged commit 1722860 into unicode-org:main Feb 12, 2025
13 checks passed
@btangmu btangmu deleted the t18294_c branch February 12, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants