-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-17484 Update dayPeriods.xml #4375
base: main
Are you sure you want to change the base?
Conversation
One small change from the ticket to minimize changes: keeping the boundary between evening and night at 9:00pm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Still fixing tests; don't review until they complete successfully. Should have marked as draft until the tests complete. |
May have to redo; guessing the spotless behavior.
Finally fixed the test failure, so we can merge this. (We already agreed that this was very unlikely to cause ICU problem [Although there might be unit tests that need adjustment, like I had to for CLDR]). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the CLDR tests, but the changes there look plausible, and the CLDR data changes look good.
@markusicu, while you were out I checked with Rich and Dragan about this one, and said it was ok. But before merging I want to check with you. |
thanks for checking; these changes are ok with me |
Also discussed in ICU TC, and agreed this is OK for CLDR 77. However ICU will likely create release candidate before this is integrated (so this would go in after that, before final release) |
One small change from the ticket to minimize changes: keeping the boundary between evening and night at 9:00pm
CLDR-17484
ALLOW_MANY_COMMITS=true