Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-13310 test that ar and children have explicit defaultNumberingSystem entry #4378

Merged
merged 1 commit into from
Feb 17, 2025
Merged

CLDR-13310 test that ar and children have explicit defaultNumberingSystem entry #4378

merged 1 commit into from
Feb 17, 2025

Conversation

pedberg-icu
Copy link
Contributor

@pedberg-icu pedberg-icu commented Feb 16, 2025 •
edited
Loading

CLDR-13310

  • This PR completes the ticket.
  • Add TestCheckNumbers to TestAll(); TestCheckNumbers was originally added in PR CLDR-11045 add back forms and enhance tests #490 for CLDR-11045 "Add no-placeholder compact data back to CLDR"
  • In TestCheckNumbers, add a test that ar and its children (except the default content locale) have explicit defaultNumberingSystem entries, since for the time being we are still supporting the possibility of having ar support either latn or arab as default (clients can choose)

ALLOW_MANY_COMMITS=true

@pedberg-icu pedberg-icu self-assigned this Feb 16, 2025
@pedberg-icu
Copy link
Contributor Author

@macchiati @srl295 @AEApple I have still not regained privileges to merge PRs. Can someone else merge this please? Thanks!

@macchiati macchiati merged commit 7d01f28 into unicode-org:main Feb 17, 2025
13 checks passed
@macchiati
Copy link
Member

Just merged

@pedberg-icu pedberg-icu deleted the CLDR-13310-test-for-defaultNumberingSystem-in-ar-and-children branch February 17, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macchiati macchiati macchiati approved these changes

@srl295 srl295 Awaiting requested review from srl295

@AEApple AEApple Awaiting requested review from AEApple

@markusicu markusicu Awaiting requested review from markusicu

Assignees

@pedberg-icu pedberg-icu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedberg-icu @macchiati