CLDR-15388 check annotations for empty values or keyword entry without name (tts) entry #4386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t name (tts) entry
pedberg-icu
commented
Feb 19, 2025
|
|
||
| public class CheckAnnotations extends CheckCLDR { | ||
| private static final Pattern ANNOTATION_PATH = Pattern.compile("//ldml/annotations/.*"); | ||
|
|
||
| // Skip tts test for these locale/cp combinations unti | ||
| // https://unicode-org.atlassian.net/browse/CLDR-18329 is fixed |
There was a problem hiding this comment.
I did not use logKnownIssue, as far as I know we cannot do that in consoleCheck tests, not sure what would happen in Survey Tool.
|
Please feel free to merge when approved, I cannot merge |
pedberg-icu
deleted the
CLDR-15388-emoji-annotations-no-empty-and-no-keys-without-tts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-15388
Add a consoleCheck test (so vetters will see it) in CheckAnnotations that:
<annotation cp=".."></annotation>or<annotation cp=".."/>).This found many missing tts errors, about which I have filed CLDR-18329. In the meantime, I added a skip for these known error cases so that CI tests will pass (I did not use logKnownIssue, as far as I know we cannot do that in consoleCheck tests, not sure what would happen in Survey Tool)
ALLOW_MANY_COMMITS=true