Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64 builds for linux and darwin #35

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

bartekpacia
Copy link
Member

@bartekpacia bartekpacia commented Nov 2, 2024

Use case

I tried to run make ensure-gfmrun while working on urfave/cli on my Apple Silicon Mac but encountered this:

$ make ensure-gfmrun
go run scripts/build.go  ensure-gfmrun
# ---> /opt/homebrew/bin/git rev-parse --show-toplevel
# ---> /Users/Bartek.Pacia/projects/cli/.local/bin/gfmrun --version
2024/11/02 22:16:20 download file from https://github.com/urfave/gfmrun/releases/download/v1.3.0/gfmrun-darwin-arm64-v1.3.0 into /Users/Bartek.Pacia/projects/cli/.local/bin/gfmrun: response 404
exit status 1
make: *** [ensure-gfmrun] Error

dearchap
dearchap previously approved these changes Nov 2, 2024
@bartekpacia
Copy link
Member Author

why is CI red?

@dearchap
Copy link
Contributor

dearchap commented Nov 3, 2024

This is what the error says

Error: example-L54.go:7:3: no required module provides package golang.org/x/example/stringutil; to add it:
	go get golang.org/x/example/stringutil

@bartekpacia
Copy link
Member Author

thanks!

seems related golang/go#61722

@bartekpacia
Copy link
Member Author

ping @dearchap :)

@bartekpacia
Copy link
Member Author

Can we merge it?

@dearchap dearchap merged commit 5bda8b7 into urfave:main Jan 4, 2025
1 check passed
@bartekpacia bartekpacia deleted the more_builds branch January 4, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants