fix: #513 sign with injected wallets on local node #527
Conversation
…account or not and acting accordingly.
✅ Deploy Preview for contracts-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #284 ↗︎
Details:
Review all test suite changes for PR #527 ↗︎ |
||||||||||||||||||||
| onError && onError(result); | ||
|
|
||
| unsubscribe(); | ||
| throw new Error(message); |
There was a problem hiding this comment.
Maybe we can provide a brief reason behind transaction failure?
There was a problem hiding this comment.
I lines 77-80 we try to decode the given error with the metadata we have. The raw result gets passed along to a potential error handler, onError and last but not least we throw a proper Error with a generic or decoded error message. Depending how the rest is implemented the error is caught or an onError provided, which then presents the error to the user somehow, either a toast popping up or a failure message.
I think that's all we could do here. 🤔
There was a problem hiding this comment.
Ah, my bad, did not notice the error decoding
peetzweg
deleted the
513-prompt-to-unlock-account-when-interacting-with-actual-wallet-accounts
branch
Resolves #513/#520 by referring to the selected account if it's a testing account or not and acting accordingly.
This is the actual change:
https://github.com/paritytech/contracts-ui/pull/527/files#diff-d22473d5f78c6d4516163586c619fa5d61e960611e085cd39c676ab0afe72e81R41-R53
The rest just got reformatted due to a now shorter line:
https://github.com/paritytech/contracts-ui/pull/527/files#diff-d22473d5f78c6d4516163586c619fa5d61e960611e085cd39c676ab0afe72e81R56-R93