chore: only runs CI on pull requests & master
#533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for contracts-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #300 ↗︎
Details:
Review all test suite changes for PR #533 ↗︎ |
||||||||||||||||||||
pgherveou
approved these changes
Nov 24, 2023
Comment on lines
+4
to
+5
| push: | ||
| branches: [master] |
There was a problem hiding this comment.
This part means it should run on any push to master, does not matter the reason/origin. So main use case here after a merge of a pull request.
on:
push:
branches: [master]And this means this workflow should run for pull requests which target master. So one opening a PR against master.
on:
pull_request:
branches: [master]https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we run some workflows for every branch even if no PR was created. As the checks are not yet relevant, we can save on the CI minutes by running them only on PRs and
masterpushes.