Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order by Raw bindings #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

hashstudio
Copy link

For the following use:

$query->orderBy(QB::raw('my_table.state = ?', ['success']));

@cdvrooman
Copy link

Shouldn't the $orderBindings and $bindings variables be initialized as array() instead of [] to maintain compatibility with PHP 5.3?

@TCB13
Copy link

TCB13 commented Oct 17, 2017

@hashstudio please fix the compatibility issue @cdvrooman noticed and add some unit tests. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants