Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all comments from man.tf when removing module #40

Merged
merged 14 commits into from
Sep 17, 2024

Conversation

maximenoel8
Copy link
Contributor

@maximenoel8 maximenoel8 commented Sep 17, 2024

Context

Depending on the comment description, it can make the module removal unstable.

Solution

In a context of removing the modules, remove all the comments that are outside modules ( root level )

Example

module "slemicro55_minion" {
  source             = "./modules/minion"
  base_configuration = module.base_core.configuration
  product_version    = "4.3-released"
  name               = "slemicro55-minion"
  image              = "slemicro55o"
  provider_settings = {
    mac                = "aa:b2:92:42:00:ca"
    memory             = 2048
  }

  server_configuration = {
    hostname = "suma-bv-43-proxy.mgr.suse.de"
  }
  auto_connect_to_master  = false
  use_os_released_updates = false
  ssh_key_path            = "./salt/controller/id_rsa.pub"

  // WORKAROUND: Does not work in sumaform, yet
  //  additional_packages = [ "venv-salt-minion" ]
  install_salt_bundle = false
}

Comments will NOT be deleted

//  WORKAROUND until https://bugzilla.suse.com/show_bug.cgi?id=1208045 gets fixed
// module "slemicro52_sshminion" {
//   source             = "./modules/sshminion"
//   base_configuration = module.base_core.configuration
//   product_version    = "4.3-released"
//   name               = "slemicro52-sshminion"
//   image              = "slemicro52-ign"
//   provider_settings = {
//     mac                = "aa:b2:92:42:00:e7"
//     memory             = 2048
//   }
//   use_os_released_updates = false
//   ssh_key_path            = "./salt/controller/id_rsa.pub"
// }

This comment will be deleted.

@maximenoel8 maximenoel8 self-assigned this Sep 17, 2024
@maximenoel8 maximenoel8 requested a review from a team September 17, 2024 11:46
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maximenoel8 maximenoel8 merged commit 2bf6ef8 into uyuni-project:master Sep 17, 2024
1 check passed
@maximenoel8 maximenoel8 deleted the add-debug-module branch September 17, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants