Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Throw bad request when line or column have negative values #298

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

MarcinVaadin
Copy link
Member

Fixes #297

Copy link

github-actions bot commented Feb 3, 2025

Artifact build on last commit: distributions.zip.
For MacOS users: there is a zip inside this zip and Finder unzips them both at once. Use unzip distributions.zip from Terminal or check solution for Archive Manager.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@MarcinVaadin MarcinVaadin enabled auto-merge (squash) February 3, 2025 11:45
Copy link
Contributor

@mgarciavaadin mgarciavaadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to reproduce it but the code looks pretty straightforward so I'll approve it.

@MarcinVaadin MarcinVaadin merged commit 8df7fdc into main Feb 5, 2025
10 checks passed
@MarcinVaadin MarcinVaadin deleted the chore/bad-request-on-negative-line-column branch February 5, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Error report] java.lang.IllegalArgumentException: line must be non negative: -2
2 participants