Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support inline auth #142

Closed
wants to merge 4 commits into from
Closed

feat: support inline auth #142

wants to merge 4 commits into from

Conversation

arturshadnik
Copy link
Member

Issue

Resolves #139

Description

  • Moved apiToken into the Auth struct. A CRD can now be applied with either a reference to a secret OR an API Token.
  • Simplified Validate() function signature, since all required info is now in the Spec, which can be passed in either from the controller or or from validatorctl in direct mode.
  • Added a sample CRD showing using inline auth
  • Went back to using canonical/gomaasclient since a new release was published with the changes we needed.

@arturshadnik arturshadnik requested a review from a team as a code owner August 23, 2024 22:15
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. new-feature Net-new feature labels Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Files Patch % Lines
internal/controller/maasvalidator_controller.go 28.57% 3 Missing and 2 partials ⚠️
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
- Coverage   74.22%   71.10%   -3.13%     
==========================================
  Files           9        9              
  Lines         357      353       -4     
==========================================
- Hits          265      251      -14     
- Misses         76       85       +9     
- Partials       16       17       +1     
Files Coverage Δ
api/v1alpha1/maasvalidator_types.go 76.92% <ø> (ø)
pkg/validate/validate.go 75.60% <100.00%> (ø)
internal/controller/maasvalidator_controller.go 45.83% <28.57%> (-23.40%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb5ba0...b69470f. Read the comment docs.

@arturshadnik arturshadnik deleted the feat/inline-auth branch August 25, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Net-new feature size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🌱 Support inline auth for MAAS in addition to k8s secret
1 participant