Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update golangci-lint, pre-commit, use global makelib #91

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

TylerGillson
Copy link
Member

Issue

Description

@TylerGillson TylerGillson requested a review from a team as a code owner June 27, 2024 19:49
@TylerGillson TylerGillson requested a review from ahmad-ibra June 27, 2024 19:49
Signed-off-by: Tyler Gillson <[email protected]>
Signed-off-by: Tyler Gillson <[email protected]>
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   45.27%   44.59%   -0.68%     
==========================================
  Files           6        6              
  Lines         296      296              
==========================================
- Hits          134      132       -2     
- Misses        154      155       +1     
- Partials        8        9       +1     
Files Coverage Δ
internal/controller/maasvalidator_controller.go 80.48% <100.00%> (-2.44%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa9da68...52623f9. Read the comment docs.

@TylerGillson TylerGillson merged commit fe809b7 into main Jun 27, 2024
7 checks passed
@TylerGillson TylerGillson deleted the ci/golangci-pre-commit branch June 27, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant