Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to Kafka producer's
partitionFor
will fail whenmax.block.ms
duration is reached.Fixes #59 and replaces #121
Motivation:
Not sure why this
setTimer
had been implemented in the first place, maybemax.block.ms
did not exist at the time, but this is no longer needed.Calls to
producer.send(...)
producer.partitionsFor(...)
are subject to themax.block.ms
configuration parameter, and aTimeoutException
will be fired past this duration.Although the failure no longer gets fired twice (like mentioned before in #59 ), it could introduce some issue in cases the cluster is slow, or network is slow. Say an user HAS to configure
max.block.ms
to a value greater than 2000, the hardcodedsetTimer
would fire BEFOREmax.block.ms
gets reached, which could block some users.