Bdellabe/e2e lmeval tests multimodal #1150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
brian-dellabetta
force-pushed
the
bdellabe/e2e-lmeval-tests-multimodal
branch
from
24c757e to
a4434cd
Compare
brian-dellabetta
force-pushed
the
bdellabe/e2e-lmeval-tests-multimodal
branch
from
05e6c32 to
646e329
Compare
Signed-off-by: Brian Dellabetta <[email protected]>
brian-dellabetta
force-pushed
the
bdellabe/e2e-lmeval-tests-multimodal
branch
from
646e329 to
20c6155
Compare
Signed-off-by: Brian Dellabetta <[email protected]>
Signed-off-by: Brian Dellabetta <[email protected]>
brian-dellabetta
dismissed stale reviews from kylesayrs and rahul-tuli
via
7b185dc
kylesayrs
approved these changes
Feb 17, 2025
rahul-tuli
approved these changes
Feb 18, 2025
dsikka
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
In order to add multimodal tests to lm_eval, I had to expand the data model and moved some hard-coded logic into conditionals.
This includes a folder re-org, so that lm-eval tests were moved out of
tests/e2eand into their owntests/lmevalfolder (they are integration+regression tests).We'll have to make sure QA team is aware of the re-org once this lands, as they might have to change the github ci/cd accordingly. This adds roughly 35 minutes of testing to the weekly tests
TEST PLAN:
No new source code