Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label org.opencontainers.image.source #190

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

robinschneider
Copy link
Contributor

@robinschneider robinschneider commented Jan 29, 2024

Dependency bots, like renovate, use the label org.opencontainers.image.source in order to show the release notes from a GitHub release in a PR with a container update.
This allows the user to efficiently update container images without the need to search for the release notes or jump to the repository.

Add the label org.opencontainers.image.source="https://github.com/vmware-tanzu/velero-plugin-for-aws" to the container image.
This helps for example Renovate to add Release Notes to PRs that update the container image.
https://docs.renovatebot.com/modules/datasource/docker/

@blackpiglet
Copy link
Contributor

@robinschneider
Thanks for the contribution.
Could you give more information on what problem this PR resolves?

@robinschneider
Copy link
Contributor Author

@blackpiglet I updated the PR description.

@reasonerjt
Copy link
Contributor

@robinschneider

Thanks for the PR.
It looks good to me, but would you mind also updating the commit message to add the description?

renovate can find release notes and show them in a PR

Signed-off-by: Robin Schneider <[email protected]>
@robinschneider
Copy link
Contributor Author

@reasonerjt I updated my commit message to include a proper description.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (682678f) 20.28% compared to head (74d6208) 20.14%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
- Coverage   20.28%   20.14%   -0.15%     
==========================================
  Files           6        6              
  Lines         557      561       +4     
==========================================
  Hits          113      113              
- Misses        436      440       +4     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reasonerjt reasonerjt merged commit 36915d4 into vmware-tanzu:main Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants