mkinitcpio: improve zfs hook #54402
Open
mkinitcpio: improve zfs hook #54402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahesford
force-pushed
the
zfs-hook-cleanup
branch
from
9d2be2d to
283da5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to my comments in #54391, I propose the following cleanup of the mkinitcpio ZFS hook. I have not yet tested these changes!
I'd be open to changing the walk for
/usrto descend from${ZFS_DATASET}to preserve the current behavior. This would still drop the mounting of all other children, which I still maintain is a job for the final init. I'm not even thrilled about mounting/usrhere, but I guess we need it to fill the gaps in theusrhook for ZFS users with mount management enabled.cc: @classabbyamp
Testing the changes