feature: External Link (in Action Block) #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbmoelker
changed the title
This was referenced Dec 28, 2024
jurgenbelien
approved these changes
Jan 6, 2025
rather than in lib/ to make it clear they should no longer be mutated
Deploying head-start with
|
| Latest commit: |
e10a9c7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://74ab6b60.head-start.pages.dev |
| Branch Preview URL: | https://feat-external-link.head-start.pages.dev |
jurgenbelien
added a commit
that referenced
this pull request
Feb 4, 2025
> [!IMPORTANT] > Depends on #234, which should be merged first. # Changes - Adds Email Link to easily send an email (with optional subject and body text). - Adds Phone Link to easily start phone call, send sms (with optional text) or contact via WhatsApp (with optional message). # Associated issue N/A # How to test 1. Open preview link 2. Navigate to Action Block demo > "Action block with Email Links" section 3. Verify all variations (mailto only, with subject, with subject + body) work 4. Navigate to Action Block demo > "Action block with Phone Links" section 5. Verify all variations (call, sms, whatsapp) work (best to check on both Android and iOS) 6. Go the the `email-and-phone-links` environment and play around with the new Email Link and Phone Link option in Action Blocks 7. Verify changes made are reflected in the web page (note: run locally as changes are not updated on deploy preview) # Checklist - [x] I have performed a self-review of my own code - [x] I have made sure that my PR is easy to review (not too big, includes comments) - ~I have made updated relevant documentation files (in project README, docs/, etc)~ - ~I have added a decision log entry if the change affects the architecture or changes a significant technology~ - [x] I have notified a reviewer <!-- Please strike through and check off all items that do not apply (rather than removing them) --> --------- Co-authored-by: Jurgen Beliën <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ExternalLinkitem toActionBlockwith requiredtitleandurlfield (with validation).openInNewTabproperty also available in the built-in links inStructuredTextfields.stylefield configuration used for theInternalLinkblock.Associated issue
N/A
How to test
external-linksenvironment and play around with the new External Link option in Action BlocksChecklist
I have made updated relevant documentation files (in project README, docs/, etc)I have added a decision log entry if the change affects the architecture or changes a significant technology