-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL.ImGui.Stride.Viewports] #673
Open
kopffarben
wants to merge
60
commits into
vvvv:main
Choose a base branch
from
kopffarben:feature/VL.ImGui.Stride.Viewports
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 36 commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
09bf3cc
BUGFIX:
kopffarben 9ee818e
BUGFIX:
kopffarben 482e798
working SceneWidget and remove Properties/launchSettings.json
kopffarben 93ec848
WIP RenderWidget with IInputSource Out
kopffarben 3e251e6
WIP
kopffarben a065910
WIP CleanUp
kopffarben aede9c9
WIP
kopffarben e423c20
Merge remote-tracking branch 'remotes/origin/main' into feature/VL.Im…
kopffarben fdc69fb
WIP
kopffarben 1318fee
Merge remote-tracking branch 'remotes/origin/main' into feature/VL.Im…
kopffarben 4d30715
WIP
kopffarben e53e513
WIP
kopffarben 75dffb6
WIP
kopffarben 74d07a3
WIP
kopffarben 04d9e0d
Merge remote-tracking branch 'remotes/origin/main' into feature/VL.Im…
kopffarben 53688ac
WIP
kopffarben 163e258
CleanUP
kopffarben 9edf8bd
remove InputManager from StrideContext ... not needed
kopffarben f28bf90
Merge remote-tracking branch 'remotes/origin/main' into feature/VL.Im…
kopffarben 893137c
Move Stride Pipeline Stuff to StrideDeviceContext
kopffarben 777c985
CleanUp
kopffarben 4a57a14
WIP
kopffarben d2410ea
WIP
kopffarben 347b9f3
WIP first buggy working version ...
kopffarben 7011c91
Working Version for Viewports
kopffarben 0f363eb
some CleanUp
kopffarben 4cfd87a
Merge remote-tracking branch 'remotes/origin/main' into feature/VL.Im…
kopffarben e27cb98
SkiaRendererWithOffset
kopffarben 9e05b53
WIP
kopffarben 060c2d2
ADD Bound to Document
kopffarben cd90ed0
revert launchSettings.json
kopffarben 9d77ae2
Closing MainWindow will close all other Windows
kopffarben c78d9ab
Add MousButtons to globalMouseState
kopffarben 60e4025
Merge remote-tracking branch 'remotes/origin/main' into feature/VL.Im…
kopffarben d9d4a7a
WIP fixed null ref on Closeing
kopffarben 57254be
fix InputSource Handeling
kopffarben 2b92219
[ImGui.Stride] Gets rid of earlier introduced hack by using same code…
azeno 679e1f8
VL.ImGui.Stride TargetFramework net8.0-windows
kopffarben 6f46662
Merge remote-tracking branch 'remotes/origin/main' into feature/VL.Im…
kopffarben bdafce1
[VL.ImGui.Skia]
kopffarben cec33a3
Merge remote-tracking branch 'remotes/origin/bugfix/issue-672' into f…
kopffarben 524c1a8
IMappedDevice add SetSourceDevice
kopffarben 71e475a
Merge branch 'main' into feature/VL.ImGui.Stride.Viewports
kopffarben a71b894
small bug-fix
kopffarben aa800be
BugFix InputManager.Remove ... breaks after a while
kopffarben 0d538d9
WIP
kopffarben 3c8c945
Add Option for Constructor(NodeContext nodeContext) to SourceGenerato…
kopffarben 72f9f29
Merge remote-tracking branch 'remotes/origin/main' into feature/VL.Im…
kopffarben 6d3f50d
fix move to second screen ... DesktopBounds from Stride for second Sc…
kopffarben 085b92a
revert launchSettings.json
kopffarben c171198
Merge remote-tracking branch 'remotes/origin/main' into feature/VL.Im…
kopffarben fda0109
so improvements in ImGuiWindows.cs
kopffarben 5623600
Refactor and improve resource management
kopffarben a461a82
Add UniqueId to RenderWidget for unique naming
kopffarben 28975d5
Enhance ImGui functionality and layout
kopffarben 2197d3e
Nicer Layout
kopffarben 5311019
Merge remote-tracking branch 'remotes/origin/main' into feature/VL.Im…
kopffarben ddfc695
Work on Helppatch
kopffarben 831f878
Bugfix KeyboardInput
kopffarben f859daf
Merge remote-tracking branch 'remotes/origin/main' into feature/VL.Im…
kopffarben File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
2,249 changes: 2,249 additions & 0 deletions
2,249
VL.ImGui.Stride/help/Basics/HowTo ImGui Windows.vl
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
using System; | ||
using System.Runtime.InteropServices; | ||
using System.Text; | ||
|
||
namespace VL.ImGui.Stride | ||
{ | ||
public class FixedAsciiString : IDisposable | ||
{ | ||
public IntPtr DataPtr { get; } | ||
|
||
public unsafe FixedAsciiString(string s) | ||
{ | ||
int byteCount = Encoding.ASCII.GetByteCount(s); | ||
DataPtr = Marshal.AllocHGlobal(byteCount + 1); | ||
fixed (char* sPtr = s) | ||
{ | ||
int end = Encoding.ASCII.GetBytes(sPtr, s.Length, (byte*)DataPtr, byteCount); | ||
((byte*)DataPtr)[end] = 0; | ||
} | ||
} | ||
|
||
public void Dispose() | ||
{ | ||
Marshal.FreeHGlobal(DataPtr); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm ok, can you point to a patch where these lines of code do make a difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the CallerInfo in Notify has the wrong transformation ... The CallerInfo in Render has the correct ... just set a breakpoint in Notify ... then you can see it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting - so this might be a bug in the Stride-Skia bridge then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, probably that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will have a look..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pushed a fix for the
SkiaRenderer
- like you say, it was indeed broken, as one could see with the Stride/Skia overlay help patch. Using a Skia Button there didn't work. Thanks for the pointer. You should be able to remove that above hack now.